mirrors/streamrip
1
0
Fork 0
mirror of https://github.com/nathom/streamrip.git synced 2024-09-19 11:18:45 -04:00
Code Issues Projects Releases Packages Wiki Activity

Check for nonzero status code after conversion

Browse source
This commit is contained in:
Nathan Thomas 2022-02-20 11:50:44 -08:00
parent b4c07138c0
commit 297ff216b2
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
streamrip/converter.py
View file

@ -81,9 +81,9 @@ class Converter:
self.command = self._gen_command()
logger.debug("Generated conversion command: %s", self.command)
process = subprocess.Popen(self.command)
process = subprocess.Popen(self.command, stderr=subprocess.PIPE)
process.wait()
if os.path.isfile(self.tempfile):
if process.returncode == 0 and os.path.isfile(self.tempfile):
if self.remove_source:
os.remove(self.filename)
logger.debug("Source removed: %s", self.filename)
@ -91,7 +91,7 @@ class Converter:
shutil.move(self.tempfile, self.final_fn)
logger.debug("Moved: %s -> %s", self.tempfile, self.final_fn)
else:
raise ConversionError("No file was returned from conversion")
raise ConversionError(f"FFmpeg output:\n{process.communicate()[1]}")
def _gen_command(self):
command = [