mirror of
https://github.com/hedgedoc/hedgedoc.git
synced 2024-09-20 16:08:48 -04:00
a9d98d4b52
Depending on how the system was setup, this bug lead to keep user's data around even after a successful deletion of user'S account. This patch will make sure the missing database constraints are implemented and missed out deletions are executed. This bug was introduced to insufficent testing after implementing the feature initially. It was well tested, using the app process itself, but the migrations where missed out. I'm currently not sure, if there was also a change in how sequelize handles cassaded deletion, since I'm unter the impression that before switching to sequelize 5, this feature has worked. But I haven't verified this. No matter what, the cleanup process is rather straight forward and will be invoked on migration, but can also be done manually using the new `bin/cleanup` script. This change will result in a release 1.6.1. Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
61 lines
1.8 KiB
JavaScript
61 lines
1.8 KiB
JavaScript
'use strict'
|
|
const { spawnSync } = require('child_process')
|
|
const path = require('path')
|
|
module.exports = {
|
|
up: function (queryInterface, Sequelize) {
|
|
const cleanup = spawnSync('./bin/cleanup', { cwd: path.resolve(__dirname, '../../') })
|
|
if (cleanup.status !== 0) {
|
|
throw new Error('Unable to cleanup')
|
|
}
|
|
return queryInterface.addConstraint('Notes', ['ownerId'], {
|
|
type: 'foreign key',
|
|
name: 'Notes_owner_fkey',
|
|
references: {
|
|
table: 'Users',
|
|
field: 'id'
|
|
},
|
|
onDelete: 'cascade'
|
|
}).then(function () {
|
|
return queryInterface.addConstraint('Revisions', ['noteId'], {
|
|
type: 'foreign key',
|
|
name: 'Revisions_note_fkey',
|
|
references: {
|
|
table: 'Notes',
|
|
field: 'id'
|
|
},
|
|
onDelete: 'cascade'
|
|
})
|
|
}).then(function () {
|
|
return queryInterface.addConstraint('Authors', ['noteId'], {
|
|
type: 'foreign key',
|
|
name: 'Author_note_fkey',
|
|
references: {
|
|
table: 'Notes',
|
|
field: 'id'
|
|
},
|
|
onDelete: 'cascade'
|
|
})
|
|
}).then(function () {
|
|
return queryInterface.addConstraint('Authors', ['userId'], {
|
|
type: 'foreign key',
|
|
name: 'Author_user_fkey',
|
|
references: {
|
|
table: 'Users',
|
|
field: 'id'
|
|
},
|
|
onDelete: 'cascade'
|
|
})
|
|
})
|
|
},
|
|
|
|
down: function (queryInterface, Sequelize) {
|
|
return queryInterface.removeConstraint('Notes', 'Notes_owner_fkey')
|
|
.then(function () {
|
|
return queryInterface.removeConstraint('Revisions', 'Revisions_note_fkey')
|
|
}).then(function () {
|
|
return queryInterface.removeConstraint('Authors', 'Author_note_fkey')
|
|
}).then(function () {
|
|
return queryInterface.removeConstraint('Authors', 'Author_user_fkey')
|
|
})
|
|
}
|
|
}
|