From de952fe3b29d46242f070fd74948d87541458c90 Mon Sep 17 00:00:00 2001 From: David Mehren Date: Fri, 4 Mar 2022 13:44:43 +0100 Subject: [PATCH] feat(auth-service): accept undefined validUntil param The `validUntil` parameter for `createTokenForUser` may be undefined in some usages. As it is easy to add handling for that here, this commit implements it. Signed-off-by: David Mehren --- src/auth/auth.service.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/auth/auth.service.ts b/src/auth/auth.service.ts index fcb555cb1..16ac4451e 100644 --- a/src/auth/auth.service.ts +++ b/src/auth/auth.service.ts @@ -56,7 +56,7 @@ export class AuthService { async createTokenForUser( user: User, identifier: string, - validUntil: TimestampMillis, + validUntil: TimestampMillis | undefined, ): Promise { user.authTokens = this.getTokensByUser(user); @@ -78,7 +78,7 @@ export class AuthService { // Tokens can only be valid for a maximum of 2 years const maximumTokenValidity = new Date().getTime() + 2 * 365 * 24 * 60 * 60 * 1000; - if (validUntil === 0 || validUntil > maximumTokenValidity) { + if (!validUntil || validUntil === 0 || validUntil > maximumTokenValidity) { token = AuthToken.create( keyId, user,