From b7e52f8166f1263c526df94de1230d43691bf228 Mon Sep 17 00:00:00 2001
From: Philip Molares <philip.molares@udo.edu>
Date: Sun, 16 May 2021 22:44:43 +0200
Subject: [PATCH] feat(notes): Use publicId in notes service

Signed-off-by: Philip Molares <philip.molares@udo.edu>
---
 src/notes/notes.service.ts | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/src/notes/notes.service.ts b/src/notes/notes.service.ts
index 481700186..b667d4776 100644
--- a/src/notes/notes.service.ts
+++ b/src/notes/notes.service.ts
@@ -32,6 +32,8 @@ import { NoteGroupPermission } from '../permissions/note-group-permission.entity
 import { GroupsService } from '../groups/groups.service';
 import { checkArrayForDuplicates } from '../utils/arrayDuplicatCheck';
 import appConfiguration, { AppConfig } from '../config/app.config';
+import base32Encode from 'base32-encode';
+import { randomBytes } from 'crypto';
 
 @Injectable()
 export class NotesService {
@@ -92,6 +94,7 @@ export class NotesService {
     newNote.revisions = Promise.resolve([
       Revision.create(noteContent, noteContent),
     ]);
+    newNote.publicId = this.generatePublicId();
     if (alias) {
       newNote.alias = alias;
       this.checkNoteIdOrAlias(alias);
@@ -164,7 +167,7 @@ export class NotesService {
     const note = await this.noteRepository.findOne({
       where: [
         {
-          id: noteIdOrAlias,
+          publicId: noteIdOrAlias,
         },
         {
           alias: noteIdOrAlias,
@@ -210,6 +213,15 @@ export class NotesService {
     }
   }
 
+  /**
+   * Generate publicId for a note.
+   * This is a randomly generated 128-bit value encoded with base32-encode using the crockford variant and converted to lowercase.
+   */
+  generatePublicId(): string {
+    const randomId = randomBytes(128);
+    return base32Encode(randomId, 'Crockford').toLowerCase();
+  }
+
   /**
    * @async
    * Delete a note
@@ -358,8 +370,7 @@ export class NotesService {
   async toNoteMetadataDto(note: Note): Promise<NoteMetadataDto> {
     const updateUser = await this.calculateUpdateUser(note);
     return {
-      // TODO: Convert DB UUID to base64
-      id: note.id,
+      id: note.publicId,
       alias: note.alias ?? null,
       title: note.title ?? '',
       createTime: (await this.getFirstRevision(note)).createdAt,