From 1fef30bebce4ec108179070f6583848369818012 Mon Sep 17 00:00:00 2001 From: Tilman Vatteroth Date: Sat, 19 Jun 2021 16:00:23 +0200 Subject: [PATCH] Add new data property to iframe that indicates if the content is ready. Some tests fail because the iframe hasn't loaded the inner hedgedoc renderer yet but cypress tries to travel through the dom and verify the render results. Signed-off-by: Tilman Vatteroth --- cypress/support/getMarkdownRenderer.ts | 2 +- src/components/editor-page/renderer-pane/render-iframe.tsx | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/cypress/support/getMarkdownRenderer.ts b/cypress/support/getMarkdownRenderer.ts index 1b772a0bd..8d4e9e4ea 100644 --- a/cypress/support/getMarkdownRenderer.ts +++ b/cypress/support/getMarkdownRenderer.ts @@ -14,7 +14,7 @@ declare namespace Cypress { Cypress.Commands.add('getMarkdownRenderer', () => { return cy - .get(`iframe[data-cy="documentIframe"]`) + .get(`iframe[data-cy="documentIframe"][data-content-ready="true"]`) .should('be.visible') .its('0.contentDocument') .should('exist') diff --git a/src/components/editor-page/renderer-pane/render-iframe.tsx b/src/components/editor-page/renderer-pane/render-iframe.tsx index ff7f5c6c1..496f25096 100644 --- a/src/components/editor-page/renderer-pane/render-iframe.tsx +++ b/src/components/editor-page/renderer-pane/render-iframe.tsx @@ -140,6 +140,7 @@ export const RenderIframe: React.FC = ({ {...(isTestMode() ? {} : { sandbox: 'allow-downloads allow-same-origin allow-scripts allow-popups' })} ref={frameReference} className={`border-0 ${frameClasses ?? ''}`} + data-content-ready={rendererReady} /> )